Add --version flag to CLI #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
swallez
suggested changes
Aug 12, 2025
Contributor
swallez
left a comment
swallez
left a comment
There was a problem hiding this comment.
Nice and simple addition, but can be made even simpler 😉
Can you update the PR? And then I'll be happy to merge it!
src/cli.rs
Outdated
|
|
||
| /// Elastic MCP server | ||
| #[derive(Debug, Parser)] | ||
| #[command(version = env!("CARGO_PKG_VERSION"))] |
Contributor
There was a problem hiding this comment.
#[command(version)] uses the Cargo version by default. Can you simplify this line?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I updated the PR 😄
Add support for --version (-V) flag to display the current version. The version is now available on-demand via CLI flag in addition to being displayed during server startup. Updates: - Add version attribute to CLI struct using clap's built-in version support - Update README.md to document the new --version flag and usage Resolves the common CLI expectation of having a version flag.
SimonKaran13
force-pushed
the
feat/add-version-flag
branch
from
e3bcd78 to
f158e20
Compare
swallez
approved these changes
Aug 18, 2025
Contributor
swallez
left a comment
swallez
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for --version (-V) flag to display the current version. The version is now available on-demand via CLI flag in addition to being displayed during server startup.
Updates:
Resolves the common CLI expectation of having a version flag.