[ML] Run QA tests on PR builds #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the option to run a subset of QA tests against a locally built distribution of elasticsearch + ml-cpp
droberts195
reviewed
Oct 31, 2023
Comment on lines
17
to
19
| - 'buildkite-agent artifact download "build/*" . --step build_test_linux-aarch64-RelWithDebInfo' | ||
| - '.buildkite/scripts/steps/run_qa_tests.sh || (cd ../elasticsearch && find x-pack -name logs | xargs tar cvzf logs.tgz && buildkite-agent artifact upload logs.tgz && false)' | ||
| depends_on: "build_test_linux-x86_64-RelWithDebInfo" |
There was a problem hiding this comment.
Why do we download the build artifacts for ARM but depend on Intel?
If we only run this on one platform I'd prefer it was Intel, because that's what we've chosen to run on in our production Cloud.
Contributor
Author
There was a problem hiding this comment.
Why do we download the build artifacts for ARM but depend on Intel?
Yeah, that's a typo, I intended it to be intel for that very reason. Plus exercising the IPEX library in due course.
Contributor
Author
|
buildkite test this please |
Contributor
Author
|
buildkite run_qa_tests on linux |
Contributor
Author
|
buildkite run_qa_tests |
Contributor
Author
|
buildkite run_qa_tests |
Contributor
Author
|
buildkite run_qa_tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to run a subset of QA tests against a locally built distribution of elasticsearch + ml-cpp