[ML] Remove allocators from cache after usage #2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy42
added
>enhancement
v8.15.0
v8.14.1
:ml
ci:run-qa-tests
Contributor
Author
|
buildkite run_qa_tests on linux |
valeriy42
added a commit
that referenced
this pull request
Jun 10, 2024
In the CBoostJsonWriteBase class, we maintain a cache of allocators that should be reused when we write new results. Although we took measures to free memory in these allocators, it was still not entirely possible. As a result, we noticed a gradual increase in memory usage by native processes due to the increasing size of the allocators in the cache. This PR ensures that the allocator is removed from the cache and the memory is freed. Backport of #2679 to 7.17
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Jun 10, 2024
In the CBoostJsonWriteBase class, we maintain a cache of allocators that should be reused when we write new results. Although we took measures to free memory in these allocators, it was still not entirely possible. As a result, we noticed a gradual increase in memory usage by native processes due to the increasing size of the allocators in the cache. This PR ensures that the allocator is removed from the cache and the memory is freed. Backport of elastic#2679 to 8.14
This was referenced Jun 10, 2024
valeriy42
added a commit
that referenced
this pull request
Jun 10, 2024
In the CBoostJsonWriteBase class, we maintain a cache of allocators that should be reused when we write new results. Although we took measures to free memory in these allocators, it was still not entirely possible. As a result, we noticed a gradual increase in memory usage by native processes due to the increasing size of the allocators in the cache. This PR ensures that the allocator is removed from the cache and the memory is freed. Backport of #2679 to 8.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
CBoostJsonWriteBaseclass, we maintain a cache of allocators that should be reused when we write new results. Although we took measures to free memory in these allocators, it was still not completely possible. As a result, we noticed a gradual increase in memory usage by native processes due to the increasing size of the allocators in the cache.This PR ensures that the allocator is removed from the cache and the memory is freed.
Related to #2664