Conditionally display videos in current version #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorelli25
added
docs
|
A docs preview will be available soon: |
dedemorton
approved these changes
Jan 26, 2021
Contributor
dedemorton
left a comment
dedemorton
left a comment
There was a problem hiding this comment.
LGTM pending visual inspection after the version changes in the docs repo are merged.
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Jan 27, 2021
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Jan 27, 2021
This was referenced Jan 27, 2021
bmorelli25
added a commit
to bmorelli25/observability-docs
that referenced
this pull request
Jan 27, 2021
bmorelli25
added a commit
that referenced
this pull request
Jan 28, 2021
bmorelli25
added a commit
that referenced
this pull request
Jan 28, 2021
bmorelli25
added a commit
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR conditionally displays videos in the observability guide when
is-current-version == true. Whenfalse, backup screenshots are displayed instead. I've looked at this a million different ways, and this is by far the easiest way to accomplish this. This PR requires two lines in theelastic/docsrepo to be changed on each minor release.Related
This PR requires an additional change in the
elastic/docsrepo before merging: elastic/docs#2044