-
Notifications
You must be signed in to change notification settings - Fork 43
update error code if ES dial connection error #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carsonip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a unit test for the new branch that you're adding?
carsonip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are talking about serverless ES that is unavailable, we might get 502 from proxy instead. Have you considered handling 502 and surfacing that as a retryable error to otel client?
isaacaflores2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@carsonip any non-elasticsearch error will return a retryable error. So if the proxy - sitting between ingest and ES - returns any error, a retryable error should be returned. @isaacaflores2 I've added a basic unit test to mock the proxy returning a |
isaacaflores2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
carsonip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit and a non-blocking question on the e2e behavior in the collector, whether the error is sanitized enough for user consumption.
|
How did this merge without passing CI first. Creating a fix quickly. |
retryable server error.elasticsearchErris not ok, it implies the ES instance could not be reached, and therefore does not return a specific ES error, but rather acode.Internalerror. The error happens on the TCP connection level.Manual Test