-
Notifications
You must be signed in to change notification settings - Fork 206
[DOCS] Add deletion sub feature privilege for cases #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label. Could you fix it @lcawl? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this @lcawl !
I do have one question about the screenshot refresh: do you think it'd be useful to expand the Cases privs to show the sub-feature privs? Or is it better to keep that area collapsed since we'll likely add to it in the future?
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
I chose to leave it unexpanded since it's a subscription feature. However, if you disagree that's fine too. I also chose to not re-add the red boxes around the pertinent privileges, since we're generally trying to make screenshots that are easier to automate. If you prefer to have those boxes here and don't mind manually maintaining, that's fine too. |
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fwiw I think it's fine not to include the red boxes in the screenshot. The image is described well enough in text that I think users will find the relevant permissions without them.
|
@lcawl ah ok, good to know and I'm totally fine not annotating the screenshot. I feel like the scope of the screenshot is limited enough that users can quickly locate where the privs are when they reference the image. |
Relates to elastic/kibana#136996
Preview
https://security-docs_2219.docs-preview.app.elstc.co/guide/en/security/master/case-permissions.html