Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 25, 2022

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2022

This pull request does not have a backport label. Could you fix it @lcawl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot removed the backport-skip label Jul 25, 2022
@lcawl lcawl marked this pull request as ready for review July 25, 2022 16:56
@lcawl lcawl requested a review from nastasha-solomon July 25, 2022 16:56
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @lcawl !

I do have one question about the screenshot refresh: do you think it'd be useful to expand the Cases privs to show the sub-feature privs? Or is it better to keep that area collapsed since we'll likely add to it in the future?

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
@lcawl
Copy link
Contributor Author

lcawl commented Jul 25, 2022

I do have one question about the screenshot refresh: do you think it'd be useful to expand the Cases privs to show the sub-feature privs?

I chose to leave it unexpanded since it's a subscription feature. However, if you disagree that's fine too. I also chose to not re-add the red boxes around the pertinent privileges, since we're generally trying to make screenshots that are easier to automate. If you prefer to have those boxes here and don't mind manually maintaining, that's fine too.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fwiw I think it's fine not to include the red boxes in the screenshot. The image is described well enough in text that I think users will find the relevant permissions without them.

@nastasha-solomon
Copy link
Contributor

@lcawl ah ok, good to know and I'm totally fine not annotating the screenshot. I feel like the scope of the screenshot is limited enough that users can quickly locate where the privs are when they reference the image.

@lcawl lcawl merged commit 8677f1d into elastic:main Jul 25, 2022
@lcawl lcawl deleted the cases-delete branch July 25, 2022 23:42
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 24, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants