[Bug] v0.11.15 new `.global_data_tags` produces error during apply

[BenB196]

Describe the bug

Observe that after upgrading to 0.11.15 the following error happens;

╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to elasticstack_fleet_agent_policy.switch_snmp,
│ provider "provider[\"registry.terraform.io/elastic/elasticstack\"].fleet"
│ produced an unexpected new value: .global_data_tags: was
│ cty.MapValEmpty(cty.Object(map[string]cty.Type{"number_value":cty.Number,
│ "string_value":cty.String})), but now null.
│ 
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵

To Reproduce
Steps to reproduce the behavior:

1. Example config

resource "elasticstack_fleet_agent_policy" "router_snmp" {
  name            = "Production Router SNMP"
  namespace       = local.default_namespace
  description     = "Policy for Prometheus SNMP monitoring for Routers"
  sys_monitoring  = false
  monitor_logs    = true
  monitor_metrics = true

  provider = elasticstack.fleet
}

3. TF operation terraform apply
4. See the error in the output '...'

╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to elasticstack_fleet_agent_policy.switch_snmp,
│ provider "provider[\"registry.terraform.io/elastic/elasticstack\"].fleet"
│ produced an unexpected new value: .global_data_tags: was
│ cty.MapValEmpty(cty.Object(map[string]cty.Type{"number_value":cty.Number,
│ "string_value":cty.String})), but now null.
│ 
│ This is a bug in the provider, which should be reported in the provider's
│ own issue tracker.
╵

Note that the plan output looks like:

  # elasticstack_fleet_agent_policy.router_snmp will be updated in-place
  ~ resource "elasticstack_fleet_agent_policy" "router_snmp" {
      + global_data_tags = {}
        id               = "bcdd0e4d-867c-4aeb-b307-e3769e4885a3"
        name             = "Production Router SNMP"
        # (6 unchanged attributes hidden)
    }

Expected behavior

No error

Versions (please complete the following information):

• OS: Linux
• Terraform Version 1.11.2
• Provider version 0.11.15
• Elasticsearch Version 8.17.1

Additional context
Add any other context about the problem here.

[gigerdo]

@BenB196 Thanks for raising this bug. Unfortunately I was not able to reproduce it.

Which provider version did you upgrade from? (Maybe that is relevant in this case).

For reference I'm using the following config:

resource "elasticstack_fleet_agent_policy" "test" {
  name            = "Test"
  namespace       = "test"
  description     = "test"
  sys_monitoring  = false
  monitor_logs    = true
  monitor_metrics = true
}

[BenB196]

@gigerdo I'm upgrading from 0.11.14

[gigerdo]

OK I found the issue here: The problem is a mixup between the two provider configs kibana and fleet. For this resource the Kibana config is also needed. The fleet config also falls back to kibana by default, so it is not necessary to define it.

If you use a provider configured like this, it should work:

provider "elasticstack" {
  kibana {
    endpoints = ["<kibana-endpoint>"]
  }
}

I have opened a small PR here to also show a correct error message instead of the one seen in the report: #1114

(Longer term we will take a look at the fleet config to see if we can merge it into kibana altogether so this confusing situation disappears)

[BenB196]

Thanks @gigerdo, adding the Kibana definition to the provider resolved this issue.