Extract integration policy test config #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors integration policy acceptance tests by extracting inline Terraform configurations into external files. The refactoring improves test maintainability by separating test configuration from test logic, following the pattern used in other parts of the codebase.
Key changes:
- Moved inline Terraform configurations to structured testdata directories
- Introduced test configuration variables for dynamic values
- Removed helper functions that generated inline HCL strings
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/fleet/integration_policy/acc_test.go | Refactored test cases to use ConfigDirectory and ConfigVariables instead of inline Config strings, added embed directive, removed helper functions |
| internal/fleet/integration_policy/testdata/.../integration_policy.tf | Multiple new test configuration files extracted from inline strings, parameterized with variables |
Comments suppressed due to low confidence (2)
internal/fleet/integration_policy/testdata/TestAccResourceIntegrationPolicySecrets/single_valued_secrets/import_test/integration_policy.tf:1
- Corrected spelling of 'api_timeput' to 'api_timeout'.
internal/fleet/integration_policy/testdata/TestAccResourceIntegrationPolicySecrets/single_valued_secrets/create/integration_policy.tf:1 - Corrected spelling of 'api_timeput' to 'api_timeout'.
...gration_policy/testdata/TestAccResourceIntegrationPolicySecretsFromSDK/integration_policy.tf
Show resolved
Hide resolved
...a/TestAccResourceIntegrationPolicySecrets/single_valued_secrets/update/integration_policy.tf
Show resolved
Hide resolved
...stAccResourceIntegrationPolicySecrets/multi-valued_secrets/import_test/integration_policy.tf
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wandergeek
previously approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1276