Sailor must validate the message being emitted

[drobiazko]

It must detect if it is a official platform message and throw an error if not.

[jhorbulyk]

What is an example of something that would fail validation? What are the requirements to pass validation?

[drobiazko]

this.emit("data", "strings are not allowed");

[hannah-bulmer]

Sailor should perform validation on all items that get emitted, accordingly, and throw an error if the provided message is somehow invalid. For example, some limitations include:

• data emitted should always be an object
• data emitted cannot contain any circular dependencies
• errors emitted are typically strings (are there exceptions to this?)
• snapshot messages must be less than 5kB
• types of keys emitted should be valid types (e.g oauth)

In general, we should always be checking

• the type of thing emitted
• if it has any circular dependencies
• its size

For this issue to be resolved, we need to

• investigate any other specific validation requirements of each of the methods emit uses
• apply validation in Sailor accordingly

[jhorbulyk]

errors emitted are typically strings (are there exceptions to this?)
Sometimes they are error objects or objects that have similar properties to errors.