Remove $mappingProperties for valid configuration #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgws
added a commit
that referenced
this pull request
Jul 9, 2015
Remove $mappingProperties for valid configuration
sirba
pushed a commit
to sirba/Elasticquent
that referenced
this pull request
Mar 7, 2021
Added serveral new features when searching by query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the second remark. It needs to be removed completely, due to the fact that the trait is defining that variable in the "using-class". The current implementation returns the following error "App\Example and Elasticquent\ElasticquentTrait define the same property ($mappingProperties) in the composition of App\Example. However, the definition differs and is considered incompatible. Class was composed". This should be fixed now.