Skip to content

Turn import/no-extraneous-dependencies on with devDependencies included #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Update actions
merged 1 commit into from
Dec 22, 2018
Merged

Turn import/no-extraneous-dependencies on with devDependencies included #8

merged 1 commit into from
Dec 22, 2018

Conversation

@vikr01
Copy link
Contributor

@vikr01 vikr01 commented Dec 20, 2018

This rule must have been turned off because of devDependencies being bundled in via webpack but still giving errors from eslint-plugin-import. With the devDependencies option turned on, errors won't occur when importing packages that are either under dependencies or devDependencies.

@vikr01 vikr01 requested a review from amilajack December 22, 2018 05:15
amilajack
amilajack approved these changes Dec 22, 2018
View reviewed changes
Copy link
Member

@amilajack amilajack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot why this was disabled. Thanks!

@vikr01 vikr01 merged commit 6892a9c into master Dec 22, 2018
@vikr01 vikr01 deleted the no-extraneous-deps branch December 22, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amilajack amilajack amilajack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vikr01 @amilajack