Skip to content

Fixes from running 2.0.0-beta.1 release#12013

Merged
jkleinsc merged 1 commit intomasterfrom
release-fix
Feb 22, 2018
Merged

Fixes from running 2.0.0-beta.1 release#12013
jkleinsc merged 1 commit intomasterfrom
release-fix

Conversation

@jkleinsc
Copy link
Copy Markdown
Member

During the 2.0.0-beta.1 release I found a couple issues with the release script.

This provides the following fixes:

  1. Remove logic to delete release branch because that branch is no longer used.
  2. Fix --validateRelease to not verify shasums when release is in draft mode since the shasums don't exist at that point.

This provides the following fixes:
1. Remove logic to delete release branch because that branch is no longer used.
2. Fix --validateRelease to not verifyShasums when release is in draft mode.
@jkleinsc jkleinsc requested a review from a team February 22, 2018 13:56
Copy link
Copy Markdown
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants