browser: provide a default filename when unable to generate from download data#7169
Merged
zcbenz merged 3 commits intoelectron:masterfrom Sep 16, 2016
Merged
Conversation
zcbenz
suggested changes
Sep 16, 2016
| content::WebContents* WebContents::OpenURLFromTab( | ||
| content::WebContents* source, | ||
| const content::OpenURLParams& params) { | ||
| if (params.disposition == SAVE_TO_DISK) { |
Contributor
There was a problem hiding this comment.
This changes current behavior and not all users want to have the ability download things from the app, we can probably just make it explicit in the new-window event and document it.
346e8b8 to
e7f1265
Compare
zcbenz
approved these changes
Sep 16, 2016
Contributor
|
Looks like the spec introduced here is consistently failing on AppVeyor with the following error: It doesn't appear to be failing though on our internal Windows build machines which is really strange. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also we didn't handle alt+click on links with no download attribute, chrome downloads for that gesture but we generate a
new-windowevent. This patch fixes it in a separate commit, can be reverted if not desired.Fixes #7151