-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi BrowserView support to BrowserWindow #16148
feat: add multi BrowserView support to BrowserWindow #16148
Conversation
is failing across several platforms, and is thus i believe consequential of this PR. |
Failed test is trying to use Change what added test with |
The CI is broken on master branch, I also see the failed test in other unrelated PRs. |
Add functions addBrowserView, removeBroserView, getBrowserViews to BrowserWindow class. Existing API as setBrowserView and getBrowserView code replaced to use new api inside.
Add functions addBrowserView, removeBroserView, getBrowserViews to BrowserWindow class. Existing API as setBrowserView and getBrowserView code replaced to use new api inside.
0c099a4
to
38816e8
Compare
For failed tests on 'ci/circleci: mas-testing-tests' run. And one with timeout on getAllWebContents probably just some slowdown on host. |
Release Notes Persisted
|
Congrats on merging your first pull request! 🎉🎉🎉 |
* feat: add multi BrowserView support to BrowserWindow Add functions addBrowserView, removeBroserView, getBrowserViews to BrowserWindow class. Existing API as setBrowserView and getBrowserView code replaced to use new api inside. * fix: for lint and osx compile errors * fix: lint error in test code * feat: add multi BrowserView support to BrowserWindow Add functions addBrowserView, removeBroserView, getBrowserViews to BrowserWindow class. Existing API as setBrowserView and getBrowserView code replaced to use new api inside. * fix: for lint and osx compile errors * fix: lint error in test code * fix: method to be accessible on mac api impl * fix: missed function declarations for mac impl * fix: use base class reset function
When I try to create a new browser view, the old one disappears. |
Hello & Thanks , |
BrowserView couldn't be detached from BrowserWindow and added to another BrowserWindow. The old window still has a reference to the view in its |
Description of Change
new feature: multi browser views support for BrowserWindow
Add functions addBrowserView, removeBroserView, getBrowserViews to BrowserWindow class.
Existing API setBrowserView and getBrowserView changed to use new API inside.
This functionality was mentioned in the initial BrowserView feature PR #9166 . And asked few times since then. Recently in a discussion #10622 .
It is a resubmit of PR #16064 as changes moved to master branch instead of 2-0-x branch.
/cc @zcbenz
Checklist
npm test
passesRelease Notes
Notes: Added support for multiple browser views per
BrowserWindow
.