build: handle arm64 node headers #20192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2019 15:20
(cherry picked from commit ff1f224)
deepak1556
approved these changes
Sep 10, 2019
MarshallOfSound
approved these changes
Sep 10, 2019
|
Release Notes Persisted
|
This was referenced Sep 10, 2019
|
I have automatically backported this PR to "7-0-x", please check out #20193 |
|
I have automatically backported this PR to "6-0-x", please check out #20194 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make sure arm64 node headers get put in the right directories and do not override windows x64 files. Resolves #20185
Checklist
Release Notes
Notes: Fix node.lib linking issue