-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 14 #1017
Merged
Merged
Version 14 #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace `pify` with `util.promisify` * Don't run CI against Node 6 * Convert from Promise syntax to `async`/`await` * Drop Promise example from docs * Update docs to indicate Node 8 requirement * Use `Object.entries` * Ignore package lock files * Upgrade `pkg-up` to `^3.0.1` * Use object spread syntax when possible * Ignore caught icon error in code coverage
* Move cli.js to a bin folder * Move source files to src folder * Move CLI code to its own file
Refactor the test helpers so that it's easier to isolate tests to run when developing.
Updates the requirements on [tempy](https://github.com/sindresorhus/tempy) to permit the latest version. - [Release notes](https://github.com/sindresorhus/tempy/releases) - [Commits](sindresorhus/tempy@v0.2.1...v0.3.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
We only need a subset of the modules available for tests, so stub them out instead.
* chore: test Travis/macOS with xcode10.1 * chore: copy codesign setup from electron/electron * chore: only run codesign test on macOS hosts
* chore: replace Electron 1.3.1 with 1.4.13 in tests
BREAKING CHANGE: The download options are completely different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
See the
NEWS.md
entries plus thegit log
for what happened here. The diff is way too big to look at (mostly because most of the files moved).