Test this module, not the builtin electron.remote; test with Electron 14, 15, 16, and 17 #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This an equivalent of electron/electron#20925. It’s needed for us to pass the test suite when we’re actually testing this module instead of Electron’s builtin remote. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Semicolons are optional in JavaScript, except when they aren’t. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
test-this-module
branch
from
ce352d0 to
dca79c2
Compare
Contributor
Author
|
Oh. The second bug was just a missing semicolon issue from when the test was ported in 972b076. With that fixed, everything passes. |
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
test-this-module
branch
from
dca79c2 to
6dfa6f0
Compare
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
changed the title
andersk
changed the title
Contributor
Author
|
With a few other fixes, the test suite now passes with Electron 14, 15, 16, and 17 (except the error In combination with #111, this will let us catch future |
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
test-this-module
branch
from
33c0ab8 to
e0b9a77
Compare
nornagon
approved these changes
Mar 15, 2022
Contributor
|
Thanks! |
|
🎉 This PR is included in version 2.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big section of the test suite has actually been testing the builtin
electron.remoterather than this module. Correcting that reveals two bugs.Promiseglobal from fix: capture the promise global to avoid userland mutation electron#20925 has been lost. Adding that back fixes the test.