Make catch clauses compatible with TypeScript 4.4 #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TypeScript 4.4, --strict implies --useUnknownInCatchVariables, so in a ‘catch (error)’ block, ‘error’ has type ‘unknown’ rather than ‘any’. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
erickzhao
approved these changes
Mar 3, 2022
Contributor
Author
|
I see you’ve added a v2.0.6 Git tag, but there’s no 2.0.6 release on NPM. (Ideally, it’d be nice if an NPM release could include #111 as well?) |
Member
|
@andersk i believe we need to re-kick a release for the module. i can handle it on monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TypeScript 4.4,
--strictimplies--useUnknownInCatchVariables, so in acatch (error)block,errorhas typeunknownrather thanany.