fix: Export types from main and renderer, fix main types #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
May 18, 2021
Contributor
Author
|
@nornagon can you review again? :) |
nornagon
approved these changes
Jun 2, 2021
This was referenced Jun 16, 2021
andersk
added a commit
to andersk/electron-remote
that referenced
this pull request
Mar 1, 2022
This was previously excluded (electron#48) because of CI failures due to index.d.ts referencing files in dist. Those references were later removed (electron#58). so we can include it again to have CI verify that index.d.ts type checks. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/electron-remote
that referenced
this pull request
Mar 1, 2022
This was previously excluded (electron#48) because of CI failures due to index.d.ts referencing files in dist. Those references were later removed (electron#58), so we can include it again to have CI verify that index.d.ts type checks. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
nornagon
pushed a commit
that referenced
this pull request
Mar 15, 2022
* fix: types for nativeImage, webContents, webFrameMain again Fixes #110. Signed-off-by: Anders Kaseorg <andersk@mit.edu> * ci: Remove Electron 11 ShareMenu and webFrameMain are new in Electron 12. Signed-off-by: Anders Kaseorg <andersk@mit.edu> * fix: Remove exclusion of index.d.ts from tsconfig This was previously excluded (#48) because of CI failures due to index.d.ts referencing files in dist. Those references were later removed (#58), so we can include it again to have CI verify that index.d.ts type checks. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #52.
This fixes #60.
cc @nornagon