-
Notifications
You must be signed in to change notification settings - Fork 127
Combine preferStickyEvents with useMultiSFU and add a url parameter #3546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: livekit
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. But I think we need to make some clean-up on the different options.
We can probably merge multiSfu and preferStickyEvent to a single userMatrix2_0 option
| label={t("developer_mode.multi_sfu.label")} | ||
| description={t("developer_mode.multi_sfu.description")} | ||
| checked={multiSfu} | ||
| disabled={!stickyEventsSupported} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we should have been checking this. MSFU can't be enabled without sticky event support by the homeserver.
|
So this implies, that we will disable the state event based multi sfu case? |
|
In that case we really should rename multi sfu to sth more general like |
I think we were already only running multisfu on sticky events based on the code, I've just removed the single SFU sticky event use case.
I've been trying to come up with a name, but I don't really know how to describe it to power users. |
Needed so that Element Web and friends can specify they want to use sticky events (to match up with slot permissions behaviour).