Skip to content

Conversation

@ryonakano
Copy link
Member

@ryonakano ryonakano commented Apr 20, 2025

Requires #167

Changes Summary

TODO

  • Re-enable the "Check for updates" workflow after merging this PR
    • It's been disabled by GitHub automatically because there are no updates to 46.x recently

@ryonakano ryonakano marked this pull request as draft April 20, 2025 01:01
@ryonakano

This comment was marked as resolved.

@ryonakano

This comment was marked as resolved.

@danirabbit

This comment was marked as resolved.

@ryonakano
Copy link
Member Author

@danirabbit Thank you for your stylesheet fix, but the issue still persists even with it.

I created a test branch named ryonakano/research-crash that uses latest main branch of stylesheet, which includes your fix, but I got the same error and crash unfortunately.

@danirabbit
Copy link
Member

@ryonakano oops you're right, I missed a spot. This should actually fix it elementary/stylesheet#1319

@ryonakano
Copy link
Member Author

@danirabbit Nice, it does fix the issue! I don't have knowledge about styles at all so I've been stuck here. Thank you very much for your investigation and fix ❤️

@danirabbit
Copy link
Member

Proposed to release new platform here: elementary/flatpak-platform#196

@ryonakano
Copy link
Member Author

Now Web fails to start with the following error:

user@elementary-8:~$ flatpak run org.gnome.Epiphany 

(epiphany:2): Gdk-ERROR **: 20:24:34.302: gdk_display_manager_get() was called before gtk_init()
user@elementary-8:~$

This seems to be failure of Web which is caused by intentional change in GTK 4.17 according to the following issue:

https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/issues/223

@danirabbit
Copy link
Member

Opened https://gitlab.gnome.org/GNOME/epiphany/-/issues/2672

@danirabbit

This comment was marked as resolved.

@ryonakano ryonakano changed the title epiphany: Update epiphany-46.5.tar.xz to 48.0 epiphany: Update epiphany-46.5.tar.xz to 48.3 May 17, 2025
@ryonakano
Copy link
Member Author

@danirabbit I investigated the startup crash and filed a fix to Epiphany:

https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1818

I temporally applied the above fix with this branch, which we remove when it's merged and released.

@ryonakano ryonakano marked this pull request as ready for review May 18, 2025 01:03
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works! No crash in settings. Everything looks right as far as I can tell

Screenshot from 2025-05-19 08 13 26

ARM failing is due to missing runtime because of elementary/flatpak-platform#199

Patch was accepted upstream so we can drop that off when 48.4 is released

Let's go 🚀

@danirabbit danirabbit merged commit 56ed574 into main May 19, 2025
1 of 2 checks passed
@danirabbit danirabbit deleted the ryonakano/bump-epiphany branch May 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants