SymbolPane: improve tooltips for C tags #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
Oct 16, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Glad both previous and same line scenarios are covered!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented more informative tooltips for Vala symbols recently. This does the same for C tags (as far as the parser allows).
The parser does not provide start and end lines for the tags, only the line on which the tag name occurs. As C methods often have the type on the previous line, the start line is decremented for methods. It is necessary to use Markup.escape_text as some C symbol definitions contain markup characters.