SourceList/Item: use GLib.Menu #1676
Merged
+14
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
Nov 17, 2025
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Makes sense and everything still works afaict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
Itemsubclasses return a GLib.Menu instead of Gtk.Menu. Then we can use Gtk.Menu only once in SourceList which will be a drop-in for Gtk.PopoverMenu during the GTK4 portafaict we don't need to insert the action group here because we've set attach widget