Skip to content

🚨 Example PR #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

🚨 Example PR #153

merged 1 commit into from
Nov 16, 2020

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 13, 2020

Playing with the code :)

@szepeviktor
Example PR
1b0bad2 
Playing with the code :)
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 13, 2020 •
edited
Loading

BTW public function getWPContentSubDirectory() : string { when a function fails it

  • returns the base value, null in PHP
  • or throws an exception

any other behavior is highly opinionated/not future-proof/unsustainable/WordPressy

@leonstafford leonstafford merged commit 8655ced into elementor:master Nov 16, 2020
@szepeviktor szepeviktor deleted the patch-3 branch November 16, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @leonstafford