Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Fixing video recording so it works in all browsers. Fixes #263 #282

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Fixing video recording so it works in all browsers. Fixes #263 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ ENV FIREFOX_VERSION="${FF_VER}" \
FIREFOX="true" \
MULTINODE="false" \
FFMPEG_FRAME_RATE=10 \
FFMPEG_CODEC_ARGS="-crf 0 -preset ultrafast -qp 0 -pix_fmt yuv420p" \
FFMPEG_CODEC_ARGS="-vcodec libx264 -preset ultrafast -pix_fmt yuv420p" \
FFMPEG_FINAL_CRF=0 \
FFMPEG_DRAW_MOUSE=1 \
VIDEO_TMP_FILE_EXTENSION="mkv" \
Expand Down
8 changes: 4 additions & 4 deletions video-rec/bin/start-video-rec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ fi

# avconv or ffmpeg
ffmpeg -f x11grab \
-framerate ${FFMPEG_FRAME_RATE} \
-video_size ${FFMPEG_FRAME_SIZE} \
-i "${DISPLAY}.0+0,0" \
-s ${FFMPEG_FRAME_SIZE} \
-i "${DISPLAY}.0" \
-draw_mouse ${FFMPEG_DRAW_MOUSE} \
${FFMPEG_CODEC_ARGS} \
-segment_format_options movflags=+faststart \
-r ${FFMPEG_FRAME_RATE} \
-y -an "${tmp_video_path}" 2>&1 &

VID_TOOL_PID=$!

# Exit all child processes properly
Expand Down