Support pulling localstack image from custom/private registry

[RyanW8]

Here you're embedding the contents of the Dockerfile into the binary/package. It's be nice if we could customize this. Specifically the ability to tell go-localstack where to pull the localstack image from. In most enterprise environments images are stored/cached in a private registry.

In the org I work for we have no access to public registries and everything must be pulled via our private registry which is a pull through cache.

[elgohr]

Did you try to configuring the private pull through cache in the daemon used by go-localstack already?
https://docs.docker.com/docker-hub/image-library/mirror/#configure-the-docker-daemon

[RyanW8]

Annoyingly we're tied to DockerDesktop which has been heavily restricted in that we can't edit the docker daemon config. So no bueno :(

[elgohr]

As you can see, the Dockerfile does a lot more than just pulling the image. I don’t see how this should work/be maintained in a custom Dockerfile.

In addition I don’t see why this project should add extra complexity just because a company (not even sponsoring) decides to add extra complexity to their individual workflow.
I’m sure that the people that restricted the environment have good reasons and a way to configure a pull through registry.

There’s a way to use this project in context of a pull through registry already (see above).

In this way I’m going to decline the PR, sorry.

[RyanW8]

We do not have a way to configure pull through registry directly. All public images are first procured into our own private registry from which we have to pull, it's not completely unreasonable to support pulling from a different registry. It's a very simple change with no real impact or additional maintenance required.

[elgohr]

At the moment we’re talking about using a custom image, rather than a pull through registry.

Custom images would need to be considered in future development and maintenance. In this way it’s a rather big impact compared to the value it would generate.

As you say in the PR, you’re not able to test this functionality in your environment.
In this way I don’t see how maintenance should work in the future at your end.