[MRG] replace boston import from sklearn #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solegalli
changed the title
solegalli
changed the title
Contributor
Author
|
The tests are still failing for unrelated reasons that I'll take care of in separate PRs |
lopuhin
approved these changes
Dec 8, 2024
Contributor
lopuhin
left a comment
lopuhin
left a comment
There was a problem hiding this comment.
Thank you @solegalli looks good 👍 Just checked the deprecation notice https://scikit-learn.org/1.0/modules/generated/sklearn.datasets.load_boston.html, but since we use it only for tests and don't expose externally, looks fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lopuhin
In this PR, I upload the boston house to the library and recreate the function from sklearn.