Fix cdev issues causing lost interrupts #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens with supervision tree restarts and only affects GPIOs that are listening on interrupts.
fhunleth
force-pushed
the
cdev-fixes2
branch
from
1f15427 to
c65604d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests to verify these will be coming in a subsequent PR since they totally
change the test infrastructure to use Linux's gpio-sim feature. It's not
possible to exercise the failure conditions as is.
Of these, the second commit is the key one that fixes the issue seen in the
field. However, the first commit fixes a glaring issue. I plan on doing more
substantial refactorings once I have the better test infrastructure in place
since I'm not happy with the code. I believe it will fix reported issues.