Update to liveview 1.x #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes have been merged into upstream: elixir-sqlite/exqlite@main...elixir-desktop:exqlite:main#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R62 Merged in elixir-sqlite/exqlite#214 and 898bd41101b738097bf
Copy over most of a fresh phoenix 1.8 generated project skeleton.
Collaborator
|
Long overdue, will look at this asap |
Collaborator
|
Hm all builds fail, but those all are other issues:
So will fix those in other PRs |
dominicletz
approved these changes
Oct 8, 2025
Contributor
Author
+1, and I think the "Build mix release" job was stuck on warnings from elixir-desktop, which should go away on the next run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major but incomplete upgrade, based on a freshly-generated phoenix 1.8 skeleton. Patches could be split up if needed, all I've done here is the minimum to get it working again.
There are a few deprecation warnings coming from the elixir-desktop dependency, we should upgrade there as well.