Skip to content

Remove sensitive options before calling after_connect #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

Remove sensitive options before calling after_connect #336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bbacf0
remove sensitive options before calling after_connect
greg-rychlewski Nov 6, 2025
891749c
format
greg-rychlewski Nov 6, 2025
888744c
fix opts
greg-rychlewski Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/db_connection/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ defmodule DBConnection.Connection do
alias DBConnection.Util

@timeout 15_000
@sensitive_opts [:parameters, :hostname, :port, :username, :password, :database]

@doc false
def start_link(mod, opts, pool, tag) do
Expand Down Expand Up @@ -234,6 +235,7 @@ defmodule DBConnection.Connection do
case apply(mod, :checkout, [state]) do
{:ok, state} ->
opts = [timeout: timeout] ++ opts
opts = Keyword.drop(opts, @sensitive_opts)
{pid, ref} = DBConnection.Task.run_child(mod, state, after_connect, opts)
timer = start_timer(pid, timeout)
s = %{s | client: {ref, :after_connect}, timer: timer, state: state}
Expand Down
Loading