Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/ecto/repo/queryable.ex
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ defmodule Ecto.Repo.Queryable do
one!(name, query_for_get_by(queryable, clauses), opts)
end

def reload(_name, [], _opts), do: []

def reload(name, [head | _] = structs, opts) when is_list(structs) do
results = all(name, query_for_reload(structs), opts)

Expand All @@ -105,6 +107,8 @@ defmodule Ecto.Repo.Queryable do
one(name, query_for_reload([struct]), opts)
end

def reload!(_name, [], _opts), do: []

def reload!(name, [head | _] = structs, opts) when is_list(structs) do
query = query_for_reload(structs)
results = all(name, query, opts)
Expand Down
8 changes: 8 additions & 0 deletions test/ecto/repo_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,14 @@ defmodule Ecto.RepoTest do
TestRepo.reload(struct_with_custom_source)
assert_received {:all, %{from: %{source: {"custom_schema", MySchema}}}}
end

test "returns empty list when given empty list" do
assert TestRepo.reload([]) == []
end

test "reload! returns empty list when given empty list" do
assert TestRepo.reload!([]) == []
end
end

defmodule DefaultOptionRepo do
Expand Down
Loading