Force primary key type on migrations #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crbelaus
approved these changes
Aug 1, 2024
Contributor
crbelaus
left a comment
crbelaus
left a comment
There was a problem hiding this comment.
Perfect. The Error and Occurrence schemas use the default settings so this change enforces that the tables are created with the same structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes a bug found on #27 , which arises when your application is configured to use other types of field which is not
bigserialfor primary keys.After this change, the migrations needed for the
ErrorTrackerenforce the typebigserialfor its primary keys.As for people that already tried to implement the library on their systems, they need to down migrate the migration in which they introduced the library and run it again after this change is released.
In normal situations we would run a migration to fix existing systems, but given that the library is less than a week old and this bug avoids using the library at all, it is safe to say that users impacted by this will not have any data stored.
Closes #27