Skip to content

Allow mounting the dashboard without parens #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

Allow mounting the dashboard without parens #33

merged 1 commit into from
Aug 6, 2024

Conversation

@crbelaus
Copy link
Contributor

@crbelaus crbelaus commented Aug 6, 2024 •
edited
Loading

Allows omitting parens for consistency with other packages such as Phoenix Live Dashboard or Oban Web.

# You can now write this
error_tracker_dashboard "/errors"

# It won't be automatically formatted to 
error_tracker_dashboard("/errors")

@crbelaus
Allow error_tracker_dashboard without parens
1c96741 
This is consistent with how other packages such as Phoenix LiveDashboard
or Oban work when mounting resources on the router.
@crbelaus crbelaus self-assigned this Aug 6, 2024
@crbelaus crbelaus added the enhancement New feature or request label Aug 6, 2024
@crbelaus crbelaus changed the title Allow error_tracker_dashboard without parens Allow mounting the dashboard without parens Aug 6, 2024
odarriba
odarriba approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@odarriba odarriba merged commit c8c73c3 into main Aug 6, 2024
@odarriba odarriba deleted the error-tracker-dashboard-parens branch August 6, 2024 15:59
@crbelaus crbelaus added this to the v0.2.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odarriba odarriba odarriba approved these changes

Assignees

@crbelaus crbelaus

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crbelaus @odarriba