Skip to content

Conversation

@odarriba
Copy link
Contributor

@odarriba odarriba commented Aug 6, 2024

This change adds four telemetry events to allow third parties to attach to events regarding the life cycle of Events and Occurrences.

It currently emits events when:

  • A new error is recorded
  • An error is marked as resolved
  • An error is marked as unresolved
  • An occurrence is stored

Documentation has been updated.

Tests are not there yet because we are actively working in setting up the test suite in #34

@odarriba odarriba self-assigned this Aug 6, 2024
@odarriba odarriba changed the title WIP: Telemetry events Telemetry events Aug 7, 2024
@odarriba odarriba requested a review from crbelaus August 7, 2024 10:36
@odarriba odarriba added the enhancement New feature or request label Aug 7, 2024
@crbelaus crbelaus modified the milestone: v0.2.0 Aug 7, 2024
Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a small suggestion to avoid loading the entire error from the database as the reason may contain a long text.

@odarriba odarriba force-pushed the add-telemetry-events branch from 6fd5f44 to a2744be Compare August 7, 2024 17:15
@odarriba odarriba force-pushed the add-telemetry-events branch from a2744be to 210f158 Compare August 7, 2024 17:16
Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@odarriba odarriba merged commit 0d8ae49 into main Aug 7, 2024
@odarriba odarriba deleted the add-telemetry-events branch August 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants