Fix navbar link to dashboard path #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The navbar does not have any independent status so it doesn't need to be a LiveComponent. Being a LiveComponent was actually problematic as it was not able to generate the proper dashboard path for linking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navbar does not have any independent status so it doesn't need to be a LiveComponent. Being a LiveComponent was actually problematic as it was not able to generate the proper dashboard path for linking.
I noticed this because I had a bunch of filters applied and wanted to clean them all by returning to the default dashboard path. Contrary to what I was expecting clicking the ErrorTracker button maintained the filters.
This happened because the
@socketassign was different from the main page socket, as the navbar was a separate LiveComponent and thus used a separate process.After this change, the link goes to the default dashboard path as expected.