Improve Errors kind parsing #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odarriba
force-pushed
the
improve-errors-kind
branch
from
d9b6284 to
e61bc5d
Compare
odarriba
force-pushed
the
improve-errors-kind
branch
from
0d8e0bb to
c949d90
Compare
Contributor
Author
|
This one is ready to be reviewed again @crbelaus |
crbelaus
reviewed
Jun 18, 2024
lib/error_tracker/schemas/error.ex
Outdated
Comment on lines
29
to
32
| %{__struct__: struct} = ex when is_exception(ex) -> | ||
| {to_string(struct), Exception.message(ex)} | ||
|
|
||
| {_kind, %{__struct__: struct} = ex} when is_exception(ex) -> |
Contributor
There was a problem hiding this comment.
Super minor suggestion for readability:
Suggested change
| %{__struct__: struct} = ex when is_exception(ex) -> | |
| {to_string(struct), Exception.message(ex)} | |
| {_kind, %{__struct__: struct} = ex} when is_exception(ex) -> | |
| %struct{} = ex when is_exception(ex) -> | |
| {to_string(struct), Exception.message(ex)} | |
| {_kind, %struct{} = ex} when is_exception(ex) -> |
Contributor
|
I was just trying it and it works great. Just added an optional comment that can be ommitted. Looks good to me! |
crbelaus
approved these changes
Jun 18, 2024
odarriba
force-pushed
the
improve-errors-kind
branch
from
614c2bc to
f8674c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands the
ErrorTracker.Error.new/2API to allow receiving exceptions in three ways:{kind, reason}{kind, exception}exceptionIf a exception is received (either with a kind or not):
kindfield is set to the struct of the exception.reasonfield is set to the message of the exception.If a
{kind, reason}is received:kindfield is set to thekindvalue converted to string.reasonfield is set to thereasonvalue converted to string.Aside from that, the dev server now includes another route to generate an
EXITsignal to thest this.