Skip to content

Handle 'mix local.rebar' command options without arguments #11650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Handle 'mix local.rebar' command options without arguments #11650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce5699
Handle 'mix local.rebar' command options without arguments
henrythebuilder Feb 18, 2022
58c3f54
Apply suggestions from code review
josevalim Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/mix/lib/mix/tasks/local.rebar.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ defmodule Mix.Tasks.Local.Rebar do

## Command line options

* `rebar PATH` - specifies a path for `rebar`

* `rebar3 PATH` - specifies a path for `rebar3`

* `--sha512` - checks the Rebar script matches the given SHA-512 checksum
Expand All @@ -44,9 +42,9 @@ defmodule Mix.Tasks.Local.Rebar do

@impl true
def run(argv) do
{opts, _, _} = OptionParser.parse(argv, switches: @switches)
{opts, args, _} = OptionParser.parse(argv, switches: @switches)

case argv do
case args do
["rebar3", path | _] ->
maybe_install_from_path(:rebar3, path, opts)

Expand All @@ -55,7 +53,7 @@ defmodule Mix.Tasks.Local.Rebar do

_ ->
Mix.raise(
"Invalid arguments given to mix local.rebar. " <>
"Invalid arguments given to mix local.rebar: #{inspect(args)}. " <>
"To find out the proper call syntax run \"mix help local.rebar\""
)
end
Expand Down