Skip to content

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Jun 1, 2022

No description provided.

@whatyouhide
Copy link
Member

@yordis can you give a bit more context on what this is doing and what the desired output is? 🙃

@yordis
Copy link
Contributor Author

yordis commented Jun 1, 2022

@whatyouhide SOOOOORRRRRRYYY I should add context since I forgot that @josevalim isn't the only one looking at this. My apologies.

Related to this PR: elixir-ecto/ecto#3916 (comment)

@josevalim
Copy link
Member

For anyone interested in trying it out, go to Ecto issues tracker and click new issue and play around: https://github.com/elixir-ecto/ecto/issues :)

yordis and others added 2 commits June 2, 2022 09:21
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
@yordis
Copy link
Contributor Author

yordis commented Jun 2, 2022

@whatyouhide hopefully the single field doesn't show the info in a weird way when people paste it. Lets see.

@josevalim josevalim merged commit 18f473d into elixir-lang:main Jun 2, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental
Copy link
Contributor

I am not too sure "Bug Report" describes all the situations,
as the description says "Tell us about something that's not working the way we (probably) intend."
I think "Report an Issue" as we used before describes better this, as a generated warning, a typo, an unclear error message, an optimization, and so on are not bugs per-se.

Well, those are my 2 cents.

@josevalim
Copy link
Member

@eksperimental i agree, can you please send a PR? :)

@eksperimental
Copy link
Contributor

@josevalim sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants