Skip to content

Conversation

eksperimental
Copy link
Contributor

@eksperimental eksperimental commented Jun 3, 2022

I tried to port everything that we had in the previous issue template, plus a few additions such as adding an agreement check box and direct links to online communities to ask questions.

You can see how the form will look like:

/cc @yordis

placeholder: |-
1. foo
2. bar
3. baz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this placeholder since it only applies for bugs.

[Slack](https://elixir-slackin.herokuapp.com),
[Discord](https://discord.gg/elixir) or in other online communities.
- type: textarea
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since elixir --version returns multiple lines, I converted this field into a textarea

value: >
Thank you for contributing to Elixir.
Please, do not use this form for guidance, questions or support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can force a line break somehow? In any case, it is not a blocker!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe doubling up the new lines. I will look into it.

Copy link
Contributor Author

@eksperimental eksperimental Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josevalim Let's merge this as it is, since i need to see the changes applied in my main branch, it is easier for me that this one gets merged, and then I submit a second PR if this is doable.

Copy link
Contributor

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Will be copying some ideas from here into other places!

Co-authored-by: José Valim <jose.valim@gmail.com>
@josevalim josevalim merged commit 98343d0 into elixir-lang:main Jun 3, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@eksperimental
Copy link
Contributor Author

eksperimental commented Jun 3, 2022

I love it! Will be copying some ideas from here into other places!

@yordis Awesome! thank you

@yordis
Copy link
Contributor

yordis commented Jun 3, 2022

💚 💙 💜 💛 ❤️

Comment on lines +15 to +16
[Slack](https://elixir-slackin.herokuapp.com),
[Discord](https://discord.gg/elixir) or in other online communities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add these links as well? I didn't add them because I wasn't sure if it was OK to promote them

Copy link
Contributor Author

@eksperimental eksperimental Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took them from elixir-lang.org sidebar so considered them sort of (probably semi-) official.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them just in case 🤷🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. I see what you mean now in that new PR. Let's see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants