Skip to content

Conversation

michallepicki
Copy link
Contributor

I hate to bring this issue up again, but it's still causing friction, see elixirforum thread

I think with this change, the only disadvantage is that the field will need to be named map even if the internal implementation changes? I don't know if changing it to something more general would be considered a breaking change or not.

@josevalim josevalim merged commit 76febea into elixir-lang:main Jun 11, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@michallepicki
Copy link
Contributor Author

Thank you for allowing for this compromise! I know it's not ideal and doesn't anticipate other fields in the top-level struct, but hopefully it won't hurt performance with any potential changes in the future

@michallepicki michallepicki deleted the patch-1 branch June 11, 2022 07:16
@bmitc
Copy link

bmitc commented Jun 11, 2022

Thank you for the fix @michallepicki and thanks for merging this in @josevalim! This is great since it gets rid of both pattern_match and opaque_match Dialyzer errors when pattern matching against %MapSet{}. 👍

Is the Elixir version this will be included in going to be 1.14?

@josevalim
Copy link
Member

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants