Use :erlang.float_to_binary/2 in Float.to_string/1 #13046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Oct 31, 2023
|
@sabiwara there are other occurrences of |
|
@josevalim yes sorry, I thought I grepped it but I obviously missed. Will fix! |
sabiwara
force-pushed
the
erl-float-to-string
branch
from
50aa992 to
7da124a
Compare
sabiwara
force-pushed
the
erl-float-to-string
branch
from
7da124a to
ced0c3d
Compare
|
Should be good now! |
josevalim
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #11220
Did a quick prop-based sanity check just to make sure there is no unexpected change in behavior / edge case: