Skip to content

Conversation

@wingyplus
Copy link
Contributor

@wingyplus wingyplus commented Sep 20, 2024

In this changeset, I changed the upload workflow to upload after we built the release artifact. So the flow will be changed to:

Screenshot 2024-09-20 235624

You can see the demo at https://github.com/wingyplus/elixir/actions/runs/11056313905.

The pros of this way is we have only a single workflow, can reuse all both nightly (main) and release (v*) versions.

I have a few tasks left to unlock the draft:

  • Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(
  • Make update builds.txt works.
  • Remove builds.hex.pm.yml

Before continue those tasks above, is this PR ok for you?

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wojtekmach
Copy link
Member

@wingyplus yup, the direction looks good to me!

@wojtekmach
Copy link
Member

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus wingyplus marked this pull request as ready for review September 25, 2024 18:00
@wingyplus
Copy link
Contributor Author

@wojtekmach The PR is ready to review now. 🙏

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

That's a good idea. I will try it tomorrow. 👍

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus
Copy link
Contributor Author

wingyplus commented Sep 26, 2024

@wojtekmach The PR is ready to review now. 🙏

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

That's a good idea. I will try it tomorrow. 👍

Done! Here is the demo https://github.com/wingyplus/elixir/actions/runs/11056148036/job/30717118796. The flush cache disabled because of if guard.

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Copy link
Member

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@josevalim josevalim merged commit 9d5af3f into elixir-lang:main Oct 2, 2024
8 of 9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@wingyplus wingyplus deleted the improve-upload-builds-hex-pm branch October 3, 2024 15:01
wingyplus pushed a commit to wingyplus/elixir that referenced this pull request Oct 10, 2024
This is regression by elixir-lang#13845. Docs artifact needs
to fetch the tags before start building it to make version selection works.

Fixes elixir-lang#13892

Signed-off-by: Thanabodee Charoenpiriyakij <thanabodee.c@linecorp.com>
wingyplus added a commit to wingyplus/elixir that referenced this pull request Oct 10, 2024
This is regression by elixir-lang#13845. Docs artifact needs
to fetch the tags before start building it to make version selection works.

Fixes elixir-lang#13892

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
wingyplus added a commit to wingyplus/elixir that referenced this pull request Oct 10, 2024
This is regression by elixir-lang#13845. Docs artifact needs
to fetch the tags before start building it to make version selection works.

Fixes elixir-lang#13892

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
josevalim pushed a commit that referenced this pull request Oct 10, 2024
This is regression by #13845. Docs artifact needs
to fetch the tags before start building it to make version selection works.

Fixes #13892

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants