Skip to content

Conversation

jonatanklosko
Copy link
Member

Follow up to #13896.

One thing to note is that :compile.file removes the file and if the compilation fails, there is no .beam file. This means that a module may be notified as changed, but it has no file on the disk. Not sure if we should convert such entries as deleted, or ignore them, or perhaps keep as changed.

@josevalim
Copy link
Member

One thing to note is that :compile.file removes the file and if the compilation fails, there is no .beam file. This means that a module may be notified as changed, but it has no file on the disk. Not sure if we should convert such entries as deleted, or ignore them, or perhaps keep as changed.

I think this is fine. If we report a module as changed, a future compilation may still go and delete it, so we always need to deal with the fact they may not be there.

@jonatanklosko
Copy link
Member Author

Updated!

@josevalim josevalim merged commit 5ec9ca5 into elixir-lang:main Oct 15, 2024
9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@jonatanklosko jonatanklosko deleted the jk-compile-notify-erl branch October 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants