Skip to content

Conversation

@dkuku
Copy link
Contributor

@dkuku dkuku commented Feb 17, 2025

I found the reason of #14268
we passed the length of left list and then the code looked like this:

left = [:b, :c]
right = [:a, :b, :c]
{parsed_right = [:a, :b], improper_right = [:c]} = split_right_list(right, length(left), [])

I added one test, and fixed two one, which looks like it's invalid currently.
There are still two failing tests - I may need a hand with this.

@dkuku
Copy link
Contributor Author

dkuku commented Feb 18, 2025

It's ready

@dkuku dkuku marked this pull request as ready for review February 18, 2025 16:41
@josevalim josevalim merged commit c65f955 into elixir-lang:main Feb 19, 2025
10 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants