Fix EEx.compile_string passing invalid options to tokenize #14835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EEx.compile_string/2 was passing all options to tokenize/2, but tokenize/2 only accepts tokenize_opt (:file, :line, :column, :indentation, :trim). This caused dialyzer to correctly flag calls with :engine or :parser_options as type errors in Elixir 1.19+. The fix filters options before passing to tokenize/2, keeping only the valid tokenize_opt keys, while still passing the full options list to EEx.Compiler.compile/3 which needs :engine, :parser_options, and custom engine options. Fixes elixir-lang#14834
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Oct 16, 2025
EEx.compile_string/2 was passing all options to tokenize/2, but tokenize/2 only accepts tokenize_opt (:file, :line, :column, :indentation, :trim). This caused dialyzer to correctly flag calls with :engine or :parser_options as type errors in Elixir 1.19+. The fix filters options before passing to tokenize/2, keeping only the valid tokenize_opt keys, while still passing the full options list to EEx.Compiler.compile/3 which needs :engine, :parser_options, and custom engine options. Fixes #14834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EEx.compile_string/2 was passing all options to tokenize/2, but tokenize/2 only accepts tokenize_opt (:file, :line, :column, :indentation, :trim). This caused dialyzer to correctly flag calls with :engine or :parser_options as type errors in Elixir 1.19+.
The fix filters options before passing to tokenize/2, keeping only the valid tokenize_opt keys, while still passing the full options list to EEx.Compiler.compile/3 which needs :engine, :parser_options, and custom engine options.
Fixes #14834