Skip to content

Fix ceil function with zero as input #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Dec 27, 2016
Merged

Fix ceil function with zero as input #5594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/elixir/lib/float.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ defmodule Float do
count = count - exp + 1023

cond do
count <= 0 -> # There is no decimal precision
count <= 0 or # There is no decimal precision
(0 == exp and <<0::52>> == significant) -> #zero or minus zero
float

count >= 104 -> # Precision beyond 15 digits
Expand Down
3 changes: 3 additions & 0 deletions lib/elixir/test/elixir/float_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ defmodule FloatTest do
assert Float.ceil(0.32453e-10) === 1.0
assert Float.ceil(-0.32453e-10) === 0.0
assert Float.ceil(1.32453e-10) === 1.0
assert Float.ceil(0.0) === 0.0
end

test "ceil/2 with precision" do
Expand All @@ -94,6 +95,8 @@ defmodule FloatTest do

assert Float.ceil(12.32453e-20, 2) === 0.01
assert Float.ceil(-12.32453e-20, 2) === 0.0

assert Float.ceil(0.0, 2) === 0.0
end

test "round/2" do
Expand Down