Do not use user defined templateDir and hooksDir

[hauleth]

This can cause problems with some user configurations as such flags can
introduce unwanted output/behaviour in some test cases.

[josevalim]

Maybe we should set GIT_CONFIG_NOSYSTEM instead?

[hauleth]

@josevalim this will only ignore system-wide git configuration, not user-wide one.

[josevalim]

I don't think we need to pass core.hooksPath here.

[josevalim]

Maybe we should pass --template "" as there is also a GIT_TEMPLATE_DIR environment variable that this configuration won't override.

[hauleth]

I just fixed this one everywhere as I am personally using this option (I do not use init.templateDir though) and thanks to that most of output from my global hooks disappeared. Maybe in this particular case it isn't needed, but I think we should keep it for consistency.

[josevalim]

If it isn't needed, then we shouldn't keep it. I don't think consistency here matters. Different commands, different options.

[hauleth]

@josevalim it is needed as there is checkout later, which will fire hook (post-checkout).

[josevalim]

@hauleth and did you look into setting --templates="" instead here and below?

[josevalim]

@josevalim this will only ignore system-wide git configuration, not user-wide one.

As the documentation for the variable suggested, we would need to set that and the HOME variable to avoid all configs. But I actually don't think that is a good idea since SSH configuration goes in the config files and we need that. :)

[josevalim]

Which hooks are invoked on remote add origin?

[josevalim]

You removed the --git-dir configuration from this previous command.

[josevalim]

Ping!

[hauleth]

@josevalim I will finish this later as I had other tasks today (in and out of work). Sorry

[josevalim]

Ping :D

[hauleth]

@josevalim updated

[josevalim]

❤️ 💚 💙 💛 💜