Include optional dependencies in extra_applications #8263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when using optional dependencies, they would not be automatically included by compile.app in extra_applications. This meant that an optional dependency would not be guaranteed to be started before the application. Forcing users to handle this logic in an ad-hoc fashion that is incompatible with releases.
ericmj
approved these changes
Oct 9, 2018
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Jan 29, 2019
Unfortunately adding optional dependencies doesn't work for umbrella
apps where each app has a different optional dependency. For example,
Ecto 3.0 has both jason and poison as optional deps. Imagine the two
umbrella children below:
foo
* ecto
* jason
bar
* ecto
* poison
* jason
Because ecto is shared with both, Ecto will include both poison and
jason, which makes`foo` fail to boot when running in isolation.
Closes #7930.
josevalim
pushed a commit
that referenced
this pull request
Jan 29, 2019
Unfortunately adding optional dependencies doesn't work for umbrella
apps where each app has a different optional dependency. For example,
Ecto 3.0 has both jason and poison as optional deps. Imagine the two
umbrella children below:
foo
* ecto
* jason
bar
* ecto
* poison
* jason
Because ecto is shared with both, Ecto will include both poison and
jason, which makes`foo` fail to boot when running in isolation.
Closes #7930.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using optional dependencies, they would
not be automatically included by compile.app in extra_applications.
This meant that an optional dependency would not be guaranteed
to be started before the application. Forcing users to handle
this logic in an ad-hoc fashion that is incompatible with
releases.