Fix divergedreq error when update changes requirement and version #9811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
commented
Feb 11, 2020
Member
Author
ericmj
left a comment
ericmj
left a comment
There was a problem hiding this comment.
I am working on adding a test for this but it is not easy since it requires a parent with a changing requirement and a child with a changing version. We don't seem to have any existing tests where the dependencies actually change during the update.
| Enum.uniq_by(with_depending(deps, all_deps), & &1.app) | ||
| else | ||
| deps | ||
| [] |
Member
Author
There was a problem hiding this comment.
We don't have to mark these as fetched since they are marked immediately after fetching.
| # | ||
| # If there is any other dependency that is not ok, we include | ||
| # it for compilation too, this is our best to try to solve the | ||
| # maximum we can at each deps.get and deps.update. |
Member
Author
There was a problem hiding this comment.
Removed this comment since it doesn't seem to be true?
Member
Author
|
Added test on hex ^. |
The fix is to mark the dependency for compilation in the Fetcher (by touching .fetch) so that the Loader wont read the version from the .app file.
ericmj
force-pushed
the
emj/update-divergereq
branch
from
f6d4794 to
6afb8b7
Compare
josevalim
approved these changes
Feb 13, 2020
Contributor
|
@josevalim @ericmj Can this fix be backported to 1.10? I keep running into #9806 every on every |
Member
Author
|
I have backported it but I don't know if there will be another 1.10 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to mark the dependency for compilation in the Fetcher (by
touching .fetch) so that the Loader wont read the version from the .app
file.
Fixes #9806.