Replace css shadow border link underline hack with text-decoration-skip: ink #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @LostKobrakai . There are two new files in this commit that i think should not be here? epub.css and app.css? Did you build assets with the --type production flag? |
|
I did a |
LostKobrakai
force-pushed
the
feature/text-decoration-skip-ink
branch
from
7e790cf to
35e8b15
Compare
|
I've updated the branch without those two files |
|
❤️ 💚 💙 💛 💜 |
LostKobrakai
added a commit
to LostKobrakai/ex_doc
that referenced
this pull request
Feb 10, 2018
Updated all the css resets for text-shadow/background, which did not already reset text-decoration as well
josevalim
pushed a commit
that referenced
this pull request
Feb 10, 2018
Updated all the css resets for text-shadow/background, which did not already reset text-decoration as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #796